Skip to content
This repository was archived by the owner on Oct 6, 2026. It is now read-only.

[Feature]: Add access scopes in Session object - #489

Merged
rezaansyed merged 1 commit into
masterfrom
scopes-in-session
Mar 19, 2021
Merged

rezaansyed merged 1 commit into
masterfrom
scopes-in-session

Conversation

@rezaansyed

@rezaansyed rezaansyed commented Mar 17, 2021 •

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

We need to store access scopes in the Session object so that apps have access to the scope granted to them after OAuth. These scopes can then be used by apps to keep track of scopes granted.

WHAT is this pull request doing?

Storing access_scopes as an instance variable in the Session object on construction and after access token exchanges.

Checklist

  • I have updated the CHANGELOG (if applicable)
  • I have followed the Shopify Python guide

@rezaansyed
rezaansyed changed the base branch from master to api-access March 17, 2021 16:24
@rezaansyed rezaansyed changed the title Scopes in session [Feature]: Scopes in session Mar 17, 2021
@rezaansyed
rezaansyed force-pushed the api-access branch 2 times, most recently from 305d868 to 03c5a16 Compare March 17, 2021 17:46
@NabeelAhsen
NabeelAhsen force-pushed the scopes-in-session branch 3 times, most recently from 39d9764 to 077a0df Compare March 17, 2021 18:33
@NabeelAhsen NabeelAhsen mentioned this pull request Mar 18, 2021
2 tasks done
@rezaansyed
rezaansyed force-pushed the api-access branch 2 times, most recently from 05b6959 to 227a56c Compare March 18, 2021 20:31
Base automatically changed from api-access to master March 18, 2021 20:58
@rezaansyed
rezaansyed marked this pull request as ready for review March 18, 2021 21:07
@rezaansyed rezaansyed self-assigned this Mar 18, 2021
@rezaansyed rezaansyed changed the title [Feature]: Scopes in session [Feature]: Add access scopes in Session object Mar 18, 2021
Comment thread shopify/session.py Resolved
Comment thread test/session_test.py Resolved

@NabeelAhsen NabeelAhsen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor non-blocking comments. LGTM

@greatestape greatestape left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulomarg paulomarg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

Comment thread test/session_test.py Resolved
@rezaansyed
rezaansyed merged commit 7396dba into master Mar 19, 2021

This branch had an error being deployed

1 failed deployment
pypi — c7238b34 Deployed Apr 9, 2024 by shopify-shipit[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants