This repository was archived by the owner on Oct 6, 2026. It is now read-only.
Repository navigation
[Feature]: Add access scopes in Session object - #489
Merged
Merged
Conversation
rezaansyed
force-pushed
the
api-access
branch
2 times, most recently
from
March 17, 2021 17:46
305d868 to
03c5a16
Compare
NabeelAhsen
force-pushed
the
scopes-in-session
branch
3 times, most recently
from
March 17, 2021 18:33
39d9764 to
077a0df
Compare
rezaansyed
force-pushed
the
api-access
branch
2 times, most recently
from
March 18, 2021 20:31
05b6959 to
227a56c
Compare
rezaansyed
force-pushed
the
scopes-in-session
branch
from
March 18, 2021 21:03
077a0df to
39e62d4
Compare
rezaansyed
marked this pull request as ready for review
March 18, 2021 21:07
rezaansyed
requested review from
NabeelAhsen,
Paulinakhew,
greatestape,
mllemango and
paulomarg
March 18, 2021 21:07
rezaansyed
force-pushed
the
scopes-in-session
branch
from
March 18, 2021 21:11
39e62d4 to
dc1d95e
Compare
NabeelAhsen
reviewed
Mar 18, 2021
NabeelAhsen
reviewed
Mar 18, 2021
NabeelAhsen
approved these changes
Mar 18, 2021
NabeelAhsen
left a comment
Contributor
There was a problem hiding this comment.
Minor non-blocking comments. LGTM
rezaansyed
force-pushed
the
scopes-in-session
branch
from
March 19, 2021 00:42
dc1d95e to
c7238b3
Compare
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We need to store access scopes in the
Sessionobject so that apps have access to the scope granted to them after OAuth. These scopes can then be used by apps to keep track of scopes granted.WHAT is this pull request doing?
Storing
access_scopesas an instance variable in theSessionobject on construction and after access token exchanges.Checklist